Feat(Grafana): Initial implementationtion of Conditions #2035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baarsgaard
force-pushed
the
feat_grafana_conditions
branch
from
801a778 to
f54e79d
Compare
github-actions
bot
added
the
documentation
Baarsgaard
requested review from
NissesSenap,
weisdd,
ishanjainn,
theSuess,
hubeadmin and
pb82
as code owners
weisdd
requested changes
Jun 4, 2025
conditions: - lastTransitionTime: "2025-05-14T21:57:17Z" message: Grafana reconcile completed observedGeneration: 3 reason: GrafanaReady status: "True" type: Ready
Baarsgaard
force-pushed
the
feat_grafana_conditions
branch
from
f54e79d to
5e386a5
Compare
weisdd
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
.status.conditions[]on theGrafanaCR.Currently the
GrafanaReadyandInvalid${KIND}OverrideConditions have been implemented.I decided to open this PR a bit early to unblock #1907.
Then plan is to create one or more follow-up PRs to add more Conditions.