Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Name field to GrafanaAlertRuleGroupSpec #1727

Merged
merged 1 commit into from
Oct 25, 2024
Merged

feat: add Name field to GrafanaAlertRuleGroupSpec #1727

merged 1 commit into from
Oct 25, 2024

Conversation

chenlujjj
Copy link
Contributor

Resolve #1716

theSuess
theSuess requested changes Oct 25, 2024
View reviewed changes
Copy link
Member

@theSuess theSuess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I found a few small code style issues but other than that, this is good to go!

api/v1beta1/grafanaalertrulegroup_types.go Outdated Show resolved Hide resolved
api/v1beta1/grafanaalertrulegroup_types.go Outdated Show resolved Hide resolved
api/v1beta1/grafanaalertrulegroup_types.go Outdated Show resolved Hide resolved
@chenlujjj chenlujjj force-pushed the feat/alertrulegroup-name branch from e58abaa to 9e6c459 Compare October 25, 2024 05:58
@chenlujjj
Copy link
Contributor Author

@theSuess Thanks for the comments, I've updated the code.

theSuess
theSuess approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@theSuess theSuess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Approved and queued for merge :)

@theSuess theSuess enabled auto-merge October 25, 2024 07:08
@theSuess theSuess added this pull request to the merge queue Oct 25, 2024
Merged via the queue into grafana:master with commit 1362de8 Oct 25, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theSuess theSuess theSuess approved these changes

@NissesSenap NissesSenap Awaiting requested review from NissesSenap NissesSenap is a code owner

@weisdd weisdd Awaiting requested review from weisdd weisdd is a code owner

@ishanjainn ishanjainn Awaiting requested review from ishanjainn ishanjainn is a code owner

@pb82 pb82 Awaiting requested review from pb82 pb82 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suggest to add Name field to GrafanaAlertRuleGroupSpec
2 participants
@chenlujjj @theSuess