Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HELM: Enable deploying additional objects with helm chart #1607

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

gitbluf
Copy link
Contributor

@gitbluf gitbluf commented Jul 8, 2024

Sometimes additional objects are needed, such as ExternalSecret for Grafana api token, (Cilium) Network policies etc.

@CLAassistant
Copy link

CLAassistant commented Jul 8, 2024

CLA assistant check
All committers have signed the CLA.

@gitbluf gitbluf changed the title Enable deploying additional objects with helm chart HELM: Enable deploying additional objects with helm chart Jul 8, 2024
@NissesSenap
Copy link
Collaborator

Hi @gitbluf , thanks for your contribution.

This is probably not where I would add Grafana API tokens, I would personally do it in the deployment solution that you have for your grafana instance since they are more tightly coupled. But I agree with networpolicy and similar features.

  • I love the extraObjects in all the grafana related helm charts.

Please run run make helm/docs to fix the CI and then I will merge the PR.

@gitbluf
Copy link
Contributor Author

gitbluf commented Jul 9, 2024

Hi @gitbluf , thanks for your contribution.

This is probably not where I would add Grafana API tokens, I would personally do it in the deployment solution that you have for your grafana instance since they are more tightly coupled. But I agree with networpolicy and similar features.

  • I love the extraObjects in all the grafana related helm charts.

Please run run make helm/docs to fix the CI and then I will merge the PR.

Hi @NissesSenap !

Just did that.

I guess external-secret(or similar) might be used in case you're using AWS Managed Grafana and the token is generated outside of the cluster(during the provisioning of it, which is our use case).

@NissesSenap
Copy link
Collaborator

That part if completely understand.
But personally, I have 2 deployments:

  • one for the grafana-operator. Which installs the CRD and the operator.
  • And the second one, that creates a grafana CR, and sets up stuff like externalSecrets.

But you can of course order your yaml how over you want, my recommendation would just be to keep stuff related to your grafan instance together with the grafana deployment. If the secret is missing when the operator tries to create the grafana deployment from the CR, Kubernetes retries will fix that part, so it's not the end of the world if the secret is there or not.

@NissesSenap NissesSenap added this pull request to the merge queue Jul 9, 2024
Merged via the queue into grafana:master with commit 20ad9dc Jul 9, 2024
14 checks passed
@gitbluf
Copy link
Contributor Author

gitbluf commented Jul 10, 2024

@NissesSenap When can we expect this change to be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants