-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HELM: Enable deploying additional objects with helm chart #1607
Conversation
Hi @gitbluf , thanks for your contribution. This is probably not where I would add Grafana API tokens, I would personally do it in the deployment solution that you have for your grafana instance since they are more tightly coupled. But I agree with networpolicy and similar features.
Please run |
Hi @NissesSenap ! Just did that. I guess external-secret(or similar) might be used in case you're using AWS Managed Grafana and the token is generated outside of the cluster(during the provisioning of it, which is our use case). |
That part if completely understand.
But you can of course order your yaml how over you want, my recommendation would just be to keep stuff related to your grafan instance together with the grafana deployment. If the secret is missing when the operator tries to create the grafana deployment from the CR, Kubernetes retries will fix that part, so it's not the end of the world if the secret is there or not. |
@NissesSenap When can we expect this change to be released? |
Sometimes additional objects are needed, such as ExternalSecret for Grafana api token, (Cilium) Network policies etc.