-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: add parentFolderUID field in GrafanaFolder CRD #1566
Feat: add parentFolderUID field in GrafanaFolder CRD #1566
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Please change the wording on the field description as the current description was unclear to me. For the other thread, this is just a minor nitpick and no need to act on it :)
Sorry, I was absent during this week. I'll try to handle the change you ask for on it. |
bfe7ad1
to
7c82d04
Compare
9752f36
to
733e68b
Compare
@aboulay-numspot could you rebase your branch and then regenerate manifests? - |
733e68b
to
e320737
Compare
@weisdd - I have rebase and remove the file. Normally it should be fine. |
5272c58
to
7fd26f5
Compare
…of ParentFolderUID field
7fd26f5
to
9d9ec87
Compare
Solves: #1222 |
@aboulay-numspot, can we specify the folder UID when creating the folder? This way, we can pre-provision the parent folder and use its UID as the parentUID for the child folder. Otherwise, I fear that the folder UID will be autogenerated and will differ in each Grafana deployment. |
Hi @atos-cosmin-gavagiuc, the aim of this MR is to add the possibility to add a parent subfolder by using it UID. To be fully honest, I prefer to keep an unitary feature inside it yet. (I would have already implemented the However, I think it could be a great functionality and it is currently supported by the Grafana provider terraform. Do you think you could create an issue about it to track the need? |
You will find an implementation of the parentFolderUID.
However, I didn't implement an e2e check because the id of the folder is generated.
CHANGELOG:
enable: nestedFolder
in default kind's Grafana configuration (hack/kind/resources/default/grafana.yaml) to enable nestedFolder and been able to test the parentFolderUID targetingDo you know if there is somewhere I can put code example that presents the use of the parentFolderUID in GrafanaFolder CR?