Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(controller-shared): simplify labelsSatisfyMatchExpressions #1542

Merged
merged 3 commits into from
May 21, 2024
Merged

chore(controller-shared): simplify labelsSatisfyMatchExpressions #1542

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f2633eb
chore(controller-shared): simplify labelsSatisfyMatchExpressions
weisdd May 19, 2024
d1f6870
chore(controller-shared): remove double-import for meta/v1
weisdd May 19, 2024
4d631f1
Merge branch 'master' into chore/simplify-labelsSatisfyMatchExpressions
weisdd May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
chore(controller-shared): simplify labelsSatisfyMatchExpressions
  • Loading branch information
@weisdd
weisdd committed May 21, 2024
commit f2633eb8d17ce01af22a8f4b1ef3c63c2545f8fd
4 changes: 0 additions & 4 deletions controllers/controller_shared.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,6 @@ func labelsSatisfyMatchExpressions(labels map[string]string, matchExpressions []
return true
}

if len(matchExpressions) == 0 {
return true
}

for _, matchExpression := range matchExpressions {
selected := false

Expand Down