Fix "choose your search engine" pop-up #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi, what is the chance that this will be approved and committed to the prod build any time soon? We make use of this kiosk in a production environment and not having this resolution is hindering visibility in our workflow. |
|
will test this out today and merge. thanks! |
|
Hello, any news regarding this change and a possible release date? |
|
@briangann do you know if there is any timeline on when this will be merged? |
|
Until it's merged, it's relatively easy to build it yourself!
|
|
sorry for the delay, i haven't had a change to test it, but will be able to later today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #137
Solution by @mburghol