[codegen] Don't Generate Go Metadata Type #1094
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… exclude from generation when Depth > 0, and exclude the metadata field from generation using this behavior in the go resource generator.
amalavet
approved these changes
Nov 17, 2025
|
|
||
| //nolint:goconst | ||
| func (g *GoTypes) generateFilesAtDepth(v cue.Value, kv *codegen.KindVersion, currDepth int, machineName string, packageName string, pathPrefix string, namePrefix string) (codejen.Files, error) { | ||
| func (g *GoTypes) generateFilesAtDepth(v cue.Value, kv *codegen.KindVersion, currDepth int, machineName string, packageName string, pathPrefix string, namePrefix string, excludeNames []string) (codejen.Files, error) { |
Contributor
There was a problem hiding this comment.
nit; consistent naming
Suggested change
| func (g *GoTypes) generateFilesAtDepth(v cue.Value, kv *codegen.KindVersion, currDepth int, machineName string, packageName string, pathPrefix string, namePrefix string, excludeNames []string) (codejen.Files, error) { | |
| func (g *GoTypes) generateFilesAtDepth(v cue.Value, kv *codegen.KindVersion, currDepth int, machineName string, packageName string, pathPrefix string, namePrefix string, excludeFields []string) (codejen.Files, error) { |
| } | ||
| } | ||
| if exclude { | ||
| return nil, nil |
Contributor
There was a problem hiding this comment.
nit; generally speaking it is best to return an sentinel error along with a nil return.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed? Why?
[codegen] Allow GoTypes Jenny to have a configurable set of fields to exclude from generation when Depth > 0, and exclude the metadata field from generation using this behavior in the go resource generator. The
metadatatype is not used and can cause confusion for users, as it is a merge of the kubernetes object metadata and the custom metadata fields which are set as annotations in the actual object type. It was previously generated for compliance with the Thema model, which is no longer an option when generating code.How was it tested?
Tested with
make generatein a test project, as well as updating the existing unit tests.Where did you document your changes?
Updated the tutorial doc to remove references to the metadata type, as that appears to be the only place it's referenced.
Notes to Reviewers