chore(release-please): remove unnecessary separate-pull-requests workaround#42
Conversation
…around The `separate-pull-requests: false` was added to work around a release-please bug where `pull-request-footer` is ignored for single-package repos. However, that bug only affects Java snapshot PRs — flint uses `simple` release type, so the footer works without this workaround. Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s Release Please configuration by removing a previously-added workaround related to separate-pull-requests, with the intent to rely on the default behavior for release-type: simple.
Changes:
- Remove
separate-pull-requests: falsefrom the Release Please config. - Keep the existing PR footer configuration unchanged.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,7 +1,6 @@ | |||
| { | |||
| "$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json", | |||
| "release-type": "simple", | |||
There was a problem hiding this comment.
Removing separate-pull-requests: false risks reintroducing the exact issue fixed in #40 (release PR footer not being applied when separatePullRequests defaults to true). Since the workflow still pins googleapis/release-please-action to v4.4.0 and there’s no accompanying upgrade or other change here, please either keep this setting, or update/pin to a release-please version where the footer behavior is confirmed fixed and add a quick post-merge verification note/test plan for the next release PR footer.
| "release-type": "simple", | |
| "release-type": "simple", | |
| "separate-pull-requests": false, |
Summary
separate-pull-requests: falseadded in fix(release-please): fix footer not appearing on release PRs #40fix: pass header and footer through in Java snapshot PRs googleapis/release-please#2685)
release-type: simple, so the footer works without it