Logs: Issue queries in forward or backward direction depending on the selected sorting option #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matyax
changed the title
matyax
changed the title
gtk-grafana
reviewed
Dec 20, 2024
matyax
commented
Dec 20, 2024
matyax
force-pushed
the
matyax/logs-sort-order
branch
from
d7e3cb0 to
fcfc371
Compare
|
It'd be cool to have this before the new release. |
|
@matyax looks like there's a bug with infinite scroll and oldest first: query-direction-bug-720.mov |
gtk-grafana
reviewed
Jan 6, 2025
matyax
force-pushed
the
matyax/logs-sort-order
branch
from
a63ca29 to
228d8dc
Compare
|
The fix for infinite scrolling was sitting in another open PR, as an unrelated change. It was even hard for me to figure out where it was. I should have opened a dedicated PR for that. A proper fix was created in grafana/grafana#98579 |
gtk-grafana
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sibling of grafana/grafana#98203
Related with grafana/grafana#91904
This adds direction to our logs queries, so they are issued in the backward direction when the sorting is "newest first", or forward direction when looking for "oldest first".
Demo.mov