fix(panel-menu): menu throwing error in logs table #968
+41
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matyax
reviewed
Dec 19, 2024
| @@ -59,22 +59,6 @@ export class PanelMenu extends SceneObjectBase<PanelMenuState> implements VizPan | |||
| constructor(state: Partial<PanelMenuState>) { | |||
| super({ ...state, addExplorationsLink: state.addExplorationsLink ?? true }); | |||
| this.addActivationHandler(() => { | |||
| const viz = findObjectOfType(this, (o) => o instanceof VizPanel, VizPanel); | |||
There was a problem hiding this comment.
We should expect that findObjectOfType doesn't find what we're looking for and account for that case. Similar to when we use Array.find().
There was a problem hiding this comment.
Isn't the problem here that we do find something with findObjectOfType, it's just the wrong viz panel?
There was a problem hiding this comment.
looks like findObject will recursively check all of the children of each parent, so it grabs the viz panel for the logs volume instead
matyax
approved these changes
Dec 19, 2024
gtk-grafana
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening panel menu was throwing an error in Logs Table because no
VizPanelancestor could be found. InterestinglyfindObjectOfTypereturned aVizPanelinstance, butsceneGraph.getAncestorthrew an error.Change the behavior to always use
sceneGraph.getAncestorand catch the error in case there's notVizPanel.