Breakdown panels: Add shared crosshairs #940
Merged
+17
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtk-grafana
changed the title
matyax
approved these changes
Dec 9, 2024
shantanualsi
pushed a commit
that referenced
this pull request
Dec 17, 2024
* feat: add shared crosshairs to breakdown views
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #934
Notes:
There is a bug with the logs panel and the time series panel, where the tooltip will show in the time series panel when hovering on logs, if the time series graph emitted any hover events before hovering over the logs panel.
I reported it here: grafana/grafana#97600
Table isn't working:
Looks like there is a bug with sorted tables and the shared crosshair: grafana/grafana#97599
But there is something else going on as well, the tooltips don't show up at all, even though the event is being emitted.
I'm going to suggest we don't add shared crosshairs for the logs panels and volume panel for now, until those issues above are resolved upstream.
Created #941 to follow up with that functionality when those bugs are resolved.