Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field labels: histogram option for numeric fields #924

Merged
merged 8 commits into from
Dec 2, 2024

Conversation

gtk-grafana
Copy link
Contributor

@gtk-grafana gtk-grafana commented Nov 26, 2024

Adds a new option for numeric fields to allow users to toggle between histogram and time series visualization types.
Also adds grouping categories to the PanelMenu.
Saves last selection in local storage as default viz for numeric panels.

image image

Without investigations:
Numeric panel:
image
Regular panel:
image

Fixes: #923

@gtk-grafana gtk-grafana self-assigned this Nov 26, 2024
@gtk-grafana gtk-grafana added the enhancement New feature or request label Nov 26, 2024
@gtk-grafana gtk-grafana marked this pull request as ready for review November 26, 2024 22:58
@gtk-grafana gtk-grafana requested a review from a team as a code owner November 26, 2024 22:58
@gtk-grafana

This comment was marked as outdated.

src/services/store.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@matyax matyax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as expected! Would appreciate if you add usage tracking and sync with narrowing.ts changes before

Copy link
Contributor

@matyax matyax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☄️ ☄️ ☄️

@gtk-grafana gtk-grafana enabled auto-merge (squash) December 2, 2024 14:43
@gtk-grafana gtk-grafana merged commit b80df8b into main Dec 2, 2024
4 checks passed
@gtk-grafana gtk-grafana deleted the gtk-grafana/issues/923/numeric-histogram branch December 2, 2024 14:49
@gtk-grafana gtk-grafana added this to the 1.0.5 milestone Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Numeric panels: Histogram option
2 participants