Logs Panel: move log panel options and add sort order #920
Conversation
…6/move-actions-into-panel-headers
| sortOrder: (logsSortOrderFromLocalStorage | ||
| ? logsSortOrderFromLocalStorage | ||
| : LogsSortOrder.Descending) as LogsSortOrder, | ||
| wrapLogMessage: Boolean(getLogOption('wrapLogMessage')), |
There was a problem hiding this comment.
This is the breaking change for line wrap (renaming wrapLInes -> wrapLogMessage), not really necessary, but it's nice to have the options here consistent with the types in the panel.
There was a problem hiding this comment.
I think it's fine to do.
gtk-grafana
changed the title
| sortOrder: (logsSortOrderFromLocalStorage | ||
| ? logsSortOrderFromLocalStorage | ||
| : LogsSortOrder.Descending) as LogsSortOrder, | ||
| wrapLogMessage: Boolean(getLogOption('wrapLogMessage')), |
There was a problem hiding this comment.
I think it's fine to do.
|
@svennergr yeah the panel tries to keep the same lines in the viewport for better or for worse. It's probably more annoying in a QA context then in a real life situation |
That's not the case in core Explore though, so somewhere is a disconnect, I think. |
|
oh, I didn't realize that! @matyax is this a bug in Explore, or Explore logs? |
matyax
deleted the
gtk-grafana/issues/916/move-actions-into-panel-headers
branch
|
I think this is the first time I see this behavior in the logs panel. Probably within LogsPanel or something about Scenes. |
Moving Log panel options to the panel header, and adding logs direction:
WARNING: Breaking change for existing log wrap setting in local storage!