Panel Menus #892
Merged
Panel Menus #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… aggregation update
…election-manual-panel-queries
…election-manual-panel-queries__combobox
…election-manual-panel-queries
…o gtk-grafana/service-selection-manual-panel-queries__combobox
…election-manual-panel-queries
…o gtk-grafana/service-selection-manual-panel-queries__combobox
…election-manual-panel-queries__combobox
…election-manual-panel-queries__combobox__service-selection-labels
…bobox__service-selection-labels' into gtk-grafana/issues/890/panel-menus
gtk-grafana
changed the base branch from
gtk-grafana/service-selection-manual-panel-queries__combobox__service-selection-labels
to
main
svennergr
reviewed
Nov 25, 2024
Comment on lines
52
to
54
| // @todo rewrite the AddToExplorationButton | ||
| // Manually activate scene | ||
| this.state.addToExplorations?.activate(); |
There was a problem hiding this comment.
👍 I can take a GH issue for that.
svennergr
reviewed
Nov 26, 2024
svennergr
reviewed
Nov 26, 2024
svennergr
approved these changes
Nov 26, 2024
Comment on lines
+103
to
+104
| const sceneGridItem = sceneGraph.getAncestor(sceneRef, SceneCSSGridItem); | ||
| const queryProvider = sceneGraph.getData(sceneGridItem); |
There was a problem hiding this comment.
Did this get lost?
#892 (comment)
There was a problem hiding this comment.
Nope, that change is what introduced the bugs on label value panels so I reverted
There was a problem hiding this comment.
Interesting, sounds good. Let's merge!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting on grafana/grafana#96865 before taking out of draft, I can remove the css hacks and wrapping element if that proposal is accepted.
Fixes: #890
Adds VizPanelMenu to all time-series
Adds link to explore to VizPanelMenu
Adds support for addToExplorations feature in VizPanelMenu
TODO:
With investigations enabled:
Without investigations enabled:
