Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shardSplitting): improve error handling #873

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

matyax
Copy link
Contributor

@matyax matyax commented Nov 5, 2024

This PR improves error handling in the shard splitting implementation. This is done by:

  • Removing the Streaming state when sharding should stop.
  • Assigning the Error state on the merged response.

@matyax matyax requested a review from a team as a code owner November 5, 2024 09:44
@matyax matyax merged commit 13f6782 into main Nov 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants