Structured metadata: Changes to ad-hoc variable doesn't run detected_fields #849
Conversation
| // if this flakes we could just assert that it's greater then 3 | ||
| expect(requestCount).toEqual(14); | ||
| expect(requestCount).toEqual(17); |
There was a problem hiding this comment.
Don't know why there is an extra row now, this shouldn't have anything to do with the functional change in this PR, I think it's a consequence of the updates to 11.3
| @@ -82,7 +82,7 @@ export class ExplorePage { | |||
| } | |||
|
|
|||
| async scrollToBottom() { | |||
| const main = this.page.locator('main#pageContent'); | |||
| const main = this.page.locator('html'); | |||
There was a problem hiding this comment.
scroll container appears to have changed in 11.3
| @@ -44,7 +44,7 @@ export class ExplorePage { | |||
| } | |||
|
|
|||
| async setDefaultViewportSize() { | |||
| await this.page.setViewportSize({ width: 1280, height: 720 }); | |||
| await this.page.setViewportSize({ width: 1280, height: 680 }); | |||
There was a problem hiding this comment.
window height also changed a bit in 11.3, which had the consequence of adding more lazy loaded elements into the viewport, bumping down the height a tiny bit so we don't have to update a bunch of assertions.
|
I'm seeing that it correctly runs with filter changes except with patterns. Test.mov |
|
@matyax great catch, I was initially thinking patterns should be fine because the patterns endpoint doesn't take detected fields, but it turns out detected_fields does take patterns! Should be fixed now |
Fixes: #847