-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service selection: Starting with labels besides service_name #813
Service selection: Starting with labels besides service_name #813
Conversation
…ds selection buggy
…getPrimaryLabelFromUrl
…service-selection-any-label-tabs
…election-any-label-tabs
…election-any-label-tabs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somehow the label count in the tabs is not aligned to the values once a tab/label is selected:
I think we should rename this placeholder to Search values
:
Can we remove the Loading services...
copy?
Screen.Recording.2024-10-11.at.11.24.32.mov
I really like the feature, great job. Something that we discussed with @zizzpudding at one point was to add +
buttons to label values next to the Select
button. I think that would bring the biggest win here.
By using that +
button, you can select a first set of labels/values at the starting page, and then click Select
to navigate away from the "ServiceSelection" page.
I don't think that's something that necessarily need to go into this PR, but something that we should definitely iterate on.
src/Components/ServiceSelectionScene/ServiceSelectionTabsScene.tsx
Outdated
Show resolved
Hide resolved
src/Components/ServiceSelectionScene/ServiceSelectionTabsScene.tsx
Outdated
Show resolved
Hide resolved
src/Components/ServiceSelectionScene/ServiceSelectionTabsScene.tsx
Outdated
Show resolved
Hide resolved
This appears to be a discrepancy in counts between volume and detected_labels. Look at CC: @trevorwhitney |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few nits, but overall LGTM!
Building on top of #801.
Fixes: #819
Allowing users to pick another label besides service_name on the service selection scene
Notes: