Fields: Fix incorrect field count #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ewing another tab
…5/labels-list-not-updated-when-switching-service
…5/labels-list-not-updated-when-switching-service
…tching-service' into gtk-grafana/issues/760/fields-count-fix
svennergr
approved these changes
Sep 13, 2024
Co-authored-by: Sven Grossmann <Svennergr@gmail.com>
…5/labels-list-not-updated-when-switching-service
Co-authored-by: Sven Grossmann <Svennergr@gmail.com>
…tching-service' into gtk-grafana/issues/760/fields-count-fix
Base automatically changed from
gtk-grafana/issues/755/labels-list-not-updated-when-switching-service
to
main
September 13, 2024 18:02
…0/fields-count-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this makes the count better, but since we're only hiding panels when the fields tab is active we're never going to have a 100% "accurate" count until we stop hiding fields that have too much cardinality to display. But this PR should solve the problem of seeing a different number of panels then the field count.
Maybe in the future we can pick a label that will be used to aggregate fields with too much cardinality.
Note: Not using main as base branch to avoid fixing e2e flake in multiple PRs.
Base branch: #757