Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [experimental] convert httpgrpc proto from gogoproto to csproto #629

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

[WIP] [experimental] convert httpgrpc proto from gogoproto to csproto #629

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f9a7a38
convert httpgrpc proto from gogoproto to csproto
francoposa Dec 20, 2024
77b39f0
strip down benchmark
francoposa Dec 21, 2024
64c3271
fix grpc code gen
francoposa Dec 21, 2024
7e26736
convert empty stub type usage in tests
francoposa Dec 21, 2024
4670abc
revert type changes; only needs reset
francoposa Dec 21, 2024
f2f9421
reset other empty stubs in tests
francoposa Dec 21, 2024
4459d89
make mod-check
francoposa Jan 2, 2025
6eb1cce
lint: add comment for blank import
francoposa Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
reset other empty stubs in tests
  • Loading branch information
@francoposa
francoposa committed Jan 6, 2025
commit f2f9421c8fca79bfdc956a77909c188807219665
2 changes: 2 additions & 0 deletions server/server_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,6 +619,7 @@ func TestTLSServer(t *testing.T) {
grpcClient := NewFakeServerClient(conn)
grpcRes, err := grpcClient.Succeed(context.Background(), &empty)
require.NoError(t, err)
empty.Reset() // reset request to compare with the response, which will not have sizeCache=1
require.EqualValues(t, &empty, grpcRes)
}

Expand Down Expand Up @@ -710,6 +711,7 @@ func TestTLSServerWithInlineCerts(t *testing.T) {
grpcClient := NewFakeServerClient(conn)
grpcRes, err := grpcClient.Succeed(context.Background(), &empty)
require.NoError(t, err)
empty.Reset() // reset request to compare with the response, which will not have sizeCache=1
require.EqualValues(t, &empty, grpcRes)
}

Expand Down