-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Net O11y K8s cluster name retrieval #648
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! This looks good to me. One thing that I think we need to do is add the inclusion of the DataDog agent apache - 2 license in NOTICE, just like we do for the other products where we've taken code from.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #648 +/- ##
==========================================
- Coverage 79.11% 77.78% -1.33%
==========================================
Files 91 93 +2
Lines 7575 7766 +191
==========================================
+ Hits 5993 6041 +48
- Misses 1255 1394 +139
- Partials 327 331 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
It also adds a network flow printer node, for simpler debug and troubleshooting.
Manually testing: