Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Net O11y K8s cluster name retrieval #648

Merged
merged 8 commits into from
Feb 29, 2024
Merged

Conversation

mariomac
Copy link
Contributor

@mariomac mariomac commented Feb 27, 2024

It also adds a network flow printer node, for simpler debug and troubleshooting.

Manually testing:

  • EKS
  • Azure
  • GCE

@mariomac mariomac added do-not-merge WIP or something that musn't be merged wip labels Feb 27, 2024
Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This looks good to me. One thing that I think we need to do is add the inclusion of the DataDog agent apache - 2 license in NOTICE, just like we do for the other products where we've taken code from.

@mariomac mariomac changed the title WIP: Net O11y K8s cluster name retrieval Net O11y K8s cluster name retrieval Feb 28, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 27.41117% with 143 lines in your changes are missing coverage. Please review.

Project coverage is 77.78%. Comparing base (d3dc33f) to head (951b41a).
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/internal/netolly/transform/k8s/clustername.go 0.00% 121 Missing ⚠️
pkg/internal/netolly/transform/k8s/kubernetes.go 50.00% 16 Missing ⚠️
pkg/internal/netolly/export/printer.go 83.33% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #648      +/-   ##
==========================================
- Coverage   79.11%   77.78%   -1.33%     
==========================================
  Files          91       93       +2     
  Lines        7575     7766     +191     
==========================================
+ Hits         5993     6041      +48     
- Misses       1255     1394     +139     
- Partials      327      331       +4     
Flag Coverage Δ
integration-test 68.84% <27.41%> (-1.09%) ⬇️
unittests 40.28% <0.50%> (-0.95%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mariomac mariomac removed do-not-merge WIP or something that musn't be merged wip labels Feb 29, 2024
@mariomac mariomac merged commit ad647b1 into grafana:main Feb 29, 2024
4 checks passed
@mariomac mariomac deleted the cluster-name branch February 29, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants