Add NOTICE file and update the release process #384
Conversation
NOTICE
Outdated
| In the event that we accidentally failed to list a required notice, please | ||
| bring it to our attention by opening a GitHub issue at | ||
| https://github.com/grafana/beyla/issues. |
There was a problem hiding this comment.
You are missing notices for libbpf and a lot of Go modules.
There was a problem hiding this comment.
OK, sounds good. I'll add them. Thanks for checking.
There was a problem hiding this comment.
We have a third_party_licenses.csv for all of the third-party libraries we use, which is generated with the Makefile. I added the file as well to the binaries and two additional notices for libbpf (vmlinux.h) and parts of ebpf-go we have in our include.
There was a problem hiding this comment.
third_party_licenses.csv includes license notices, but it misses copywrite notices.
There was a problem hiding this comment.
I added wording to say that the copyright for the third party libraries belongs to the authors of the third party libraries.
There was a problem hiding this comment.
Probably it would be the best if you check this with legals.
I have no other comments.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #384 +/- ##
==========================================
- Coverage 81.35% 81.26% -0.10%
==========================================
Files 53 53
Lines 4120 4120
==========================================
- Hits 3352 3348 -4
- Misses 584 592 +8
+ Partials 184 180 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This PR adds a NOTICE file to Beyla with the attribution to OpenTelemetry Go Autoinstrumentation. The PR also changes our release process to include our LICENSE and the new NOTICE file in our distributions, tar and Docker.
Closes #378