Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes panic on Go instrumentation #1475

Closed
wants to merge 1 commit into from
Closed

Conversation

mariomac
Copy link
Contributor

On ELF parse error, we return the list of missing fields, assuming that we would stop the instrumentation. There is an edge case error on which the missing fields set is empty so Beyla keeps with the instrumentation, but the returned list of fields is nil

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.03%. Comparing base (1192264) to head (483a2c9).

Files with missing lines Patch % Lines
pkg/internal/goexec/structmembers.go 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (1192264) and HEAD (483a2c9). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (1192264) HEAD (483a2c9)
unittests 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1475      +/-   ##
==========================================
- Coverage   81.45%   73.03%   -8.43%     
==========================================
  Files         149      148       -1     
  Lines       15253    15244       -9     
==========================================
- Hits        12425    11133    -1292     
- Misses       2228     3386    +1158     
- Partials      600      725     +125     
Flag Coverage Δ
integration-test 59.77% <0.00%> (-0.01%) ⬇️
k8s-integration-test 60.77% <0.00%> (+0.90%) ⬆️
oats-test 34.02% <0.00%> (ø)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mariomac mariomac marked this pull request as ready for review December 20, 2024 16:20
@rafaelroquetto
Copy link
Contributor

Carried over to #1476

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants