Helm: do not override default exclusions from 'discovery' #1473
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1454
This changes how the ConfigMap contents are generated. I'm not 100% happy with how it works, but it is the best solution that I could come up with without introducing breaking changes.
config.data
to a new template intemplates/_config.tpl
beyla.defaultConfig
template in that file define the original default configuration, retaining thosepreset
valuesbeyla.config
template mergesconfig.data
with the output ofbeyla.defaultConfig
, giving precedence toconfig.data
Caveats are:
templates/_config.tpl
, while I could technically leave the same default configurations inconfig.data
as well, but that could be confusingdiscovery: {}
would not actually clear the discovery configuration as the default configuration is set. The only way to remove it in this case is to set it to null.I think the logical problem here stems mostly from the
preset
configuration (network or application) intersecting with just taking all values fromconfig.data
. It might be advisable to change/remove that, but that will of course be a breaking change.