Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing http2 connection info #1464

Merged
merged 3 commits into from
Dec 14, 2024

Conversation

rafaelroquetto
Copy link
Contributor

Golang can upgrade an SSL connection from HTTP1.1 to HTTP2 if the server supports it. We were missing a probe and offsets information for the vendored Go http2 functions to be able to fetch the connection information properly.

Closes #1430

(This is a rebase of the original PR: #1461)

Copy link

codecov bot commented Dec 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.11%. Comparing base (0d8cdc3) to head (b7a3c42).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1464      +/-   ##
==========================================
- Coverage   81.17%   81.11%   -0.06%     
==========================================
  Files         149      149              
  Lines       15339    15342       +3     
==========================================
- Hits        12451    12445       -6     
- Misses       2274     2280       +6     
- Partials      614      617       +3     
Flag Coverage Δ
integration-test 59.67% <100.00%> (-0.01%) ⬇️
k8s-integration-test 60.55% <100.00%> (-0.15%) ⬇️
oats-test 33.82% <100.00%> (+0.01%) ⬆️
unittests 51.79% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rafaelroquetto rafaelroquetto merged commit 5770689 into main Dec 14, 2024
15 checks passed
@rafaelroquetto rafaelroquetto deleted the fix_missing_http2_connection_info branch December 14, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants