Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SQL detection #1427

Merged
merged 7 commits into from
Dec 3, 2024
Merged

Fix SQL detection #1427

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1397b0b
more precise sql detection
grcevski Dec 2, 2024
8c8f6f2
fix bugs
grcevski Dec 2, 2024
d3ed7f8
Add mysql test, fix bugs with tcp SSL
grcevski Dec 2, 2024
1f54ec7
Add support for prepared mysql statements, integration tests
grcevski Dec 2, 2024
4024a4e
Add support for mysql, postgres
grcevski Dec 2, 2024
27c897e
docs for the new option
grcevski Dec 2, 2024
ac119b9
test fixes
grcevski Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test fixes
  • Loading branch information
@grcevski
grcevski committed Dec 3, 2024
commit ac119b94b1682f4b9dfb929ed713984e7c2bbb5c
4 changes: 0 additions & 4 deletions pkg/internal/ebpf/common/tcp_detect_transform.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ package ebpfcommon
import (
"bytes"
"encoding/binary"
"fmt"

"github.com/cilium/ebpf/ringbuf"

Expand Down Expand Up @@ -36,9 +35,6 @@ func ReadTCPRequestIntoSpan(cfg *config.EPPFTracer, record *ringbuf.Record, filt

b := event.Buf[:l]

fmt.Printf("b: %v\n", b)
fmt.Printf("rb: %v\n", event.Rbuf[:rl])

// Check if we have a SQL statement
op, table, sql, kind := detectSQLPayload(cfg.HeuristicSQLDetect, b)
if validSQL(op, table) {
Expand Down
1 change: 1 addition & 0 deletions test/oats/kafka/yaml/oats_python_kafka.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ expected:
- traceql: '{ .messaging.operation.type = "process" }'
spans:
- name: 'my-topic process'
allow-duplicates: true
attributes:
messaging.destination.name: my-topic
messaging.operation.type: process
Expand Down
Loading