Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure ring buf maps have sane max entries values #1374

Merged
merged 5 commits into from
Nov 18, 2024
Merged

Conversation

rafaelroquetto
Copy link
Contributor

RingBuf map type must be a multiple of the underlying OS page size.

Resolves #1368

@rafaelroquetto
Copy link
Contributor Author

@gouthamve are you able to test and report back?

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.06%. Comparing base (d52d50e) to head (64042d5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1374      +/-   ##
==========================================
+ Coverage   80.94%   81.06%   +0.12%     
==========================================
  Files         147      147              
  Lines       14762    14770       +8     
==========================================
+ Hits        11949    11974      +25     
+ Misses       2230     2212      -18     
- Partials      583      584       +1     
Flag Coverage Δ
integration-test 58.61% <100.00%> (+0.18%) ⬆️
k8s-integration-test 59.96% <100.00%> (+0.24%) ⬆️
oats-test 34.12% <100.00%> (+0.05%) ⬆️
unittests 51.84% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

pkg/internal/ebpf/tracer_linux.go Outdated Show resolved Hide resolved
@rafaelroquetto rafaelroquetto merged commit fcc176f into main Nov 18, 2024
13 checks passed
@rafaelroquetto rafaelroquetto deleted the page_size branch November 18, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Beyla doesn't work when page size is bigger than 4K
2 participants