Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal instrumentation for k8s cache #1365

Merged
merged 5 commits into from
Nov 18, 2024

Conversation

mariomac
Copy link
Contributor

@mariomac mariomac commented Nov 15, 2024

Will provide a view of how much load is the k8s cache carrying out.

Done:

  • Integration tests.
  • Modify helm chart.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 91.04478% with 12 lines in your changes missing coverage. Please review.

Project coverage is 78.46%. Comparing base (e766187) to head (5e863de).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/kubecache/meta/informers_init.go 64.28% 0 Missing and 5 partials ⚠️
pkg/kubecache/instrument/imetrics.go 95.50% 4 Missing ⚠️
pkg/kubecache/instrument/server.go 82.35% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1365      +/-   ##
==========================================
+ Coverage   78.35%   78.46%   +0.11%     
==========================================
  Files         145      147       +2     
  Lines       14639    14762     +123     
==========================================
+ Hits        11470    11583     +113     
- Misses       2570     2576       +6     
- Partials      599      603       +4     
Flag Coverage Δ
k8s-integration-test 59.84% <83.58%> (+0.24%) ⬆️
oats-test 34.18% <0.00%> (-0.17%) ⬇️
unittests 51.84% <22.38%> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@mariomac mariomac marked this pull request as ready for review November 18, 2024 13:35
@mariomac mariomac merged commit d52d50e into grafana:main Nov 18, 2024
11 of 12 checks passed
@mariomac mariomac deleted the internal-metrics branch November 18, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants