Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some informer optimizations #1360

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Conversation

mariomac
Copy link
Contributor

Removes some messages that were flooding debug log.

Prevents forwarding headless services to the client.

Slightly optimizes the informers' storage.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 80.96%. Comparing base (3a57830) to head (8d52cd9).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pkg/kubecache/meta/informers.go 25.00% 2 Missing and 1 partial ⚠️
pkg/kubecache/meta/informers_init.go 88.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1360      +/-   ##
==========================================
+ Coverage   72.13%   80.96%   +8.83%     
==========================================
  Files         144      145       +1     
  Lines       14661    14665       +4     
==========================================
+ Hits        10575    11873    +1298     
+ Misses       3390     2216    -1174     
+ Partials      696      576     -120     
Flag Coverage Δ
integration-test 59.04% <0.00%> (+0.11%) ⬆️
k8s-integration-test 59.72% <70.00%> (+0.06%) ⬆️
oats-test 34.31% <0.00%> (+0.01%) ⬆️
unittests 52.25% <70.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mariomac mariomac merged commit a09e534 into grafana:main Nov 15, 2024
13 checks passed
@mariomac mariomac deleted the infor-optimizations branch November 15, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants