Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kube meta store: Make sure all the object metadata is deleted #1359

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

mariomac
Copy link
Contributor

I detected a memory leak in some Beyla instances even when they don't run the informers code.

Pyroscope points to Store.deleteObjectMeta as a source of memory growth:

image

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.00%. Comparing base (c4244b1) to head (5e4f425).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1359      +/-   ##
==========================================
+ Coverage   79.06%   81.00%   +1.94%     
==========================================
  Files         145      145              
  Lines       14648    14655       +7     
==========================================
+ Hits        11581    11871     +290     
+ Misses       2489     2210     -279     
+ Partials      578      574       -4     
Flag Coverage Δ
integration-test 58.97% <0.00%> (+0.07%) ⬆️
k8s-integration-test 59.54% <100.00%> (+0.15%) ⬆️
oats-test 34.36% <0.00%> (?)
unittests 52.11% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mariomac mariomac merged commit 4b1755e into grafana:main Nov 15, 2024
13 checks passed
@mariomac mariomac deleted the om-delete branch November 15, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants