Extract ReplicaSet name from pod name #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariomac
requested review from
grcevski,
marctc and
rafaelroquetto
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1202 +/- ##
==========================================
- Coverage 81.11% 71.81% -9.31%
==========================================
Files 136 135 -1
Lines 11501 11497 -4
==========================================
- Hits 9329 8256 -1073
- Misses 1640 2580 +940
- Partials 532 661 +129
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mariomac
force-pushed
the
extract-rs
branch
from
1b44502 to
aa1d93c
Compare
mariomac
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #1198
A ReplicaSet informer should not be actually required, as it is only used to extract the top-level name of a deployment, and this name is actually part of the ReplicaSet name.
This PR only considers the case where the ReplicaSet informer is disabled.
A future PR could disable the ReplicaSet informer by default, or even delete it for code simplification.