Use struct with pid and Go routine addr for Go BPF maps #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marctc
requested review from
grcevski,
mariomac and
rafaelroquetto
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1201 +/- ##
=======================================
Coverage 81.95% 81.96%
=======================================
Files 136 136
Lines 11420 11420
=======================================
+ Hits 9359 9360 +1
+ Misses 1534 1533 -1
Partials 527 527
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
marctc
force-pushed
the
use_structs_go_maps_2
branch
from
2a2abf3 to
96a411c
Compare
mariomac
reviewed
Sep 27, 2024
test/integration/suites_test.go
Outdated
| @@ -498,6 +498,7 @@ func TestSuite_OverrideServiceName(t *testing.T) { | |||
| } | |||
|
|
|||
| func TestSuiteNodeClient(t *testing.T) { | |||
| t.Skip("seems flaky, we need to look into this") | |||
There was a problem hiding this comment.
You can reenable them if you merge your branch with main.
bpf/go_grpc.h
Outdated
| @@ -150,7 +150,7 @@ int uprobe_netFdReadGRPC(struct pt_regs *ctx) { | |||
| bpf_dbg_printk("tr %llx", tr); | |||
| if (tr) { | |||
| go_addr_key_t tr_key = {}; | |||
| go_addr_key_from_id(&tr_key, tr); | |||
| go_addr_key_from_id(&tr_key, (u64 *)tr); | |||
There was a problem hiding this comment.
This looks strange, given go_addr_key_from_id takes a void*, I'd expect this to have no side-effect.
marctc
force-pushed
the
use_structs_go_maps_2
branch
from
2e97c49 to
9f41828
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up PR of #1182
Change more BPF maps to use structs with addr + PID.