Fix linting/compilation on Darwin environments #1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariomac
requested review from
grcevski,
marctc and
rafaelroquetto
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1199 +/- ##
==========================================
+ Coverage 81.07% 81.14% +0.06%
==========================================
Files 136 136
Lines 11501 11501
==========================================
+ Hits 9324 9332 +8
+ Misses 1643 1639 -4
+ Partials 534 530 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rafaelroquetto
approved these changes
Sep 25, 2024
| @@ -9,3 +9,7 @@ func CheckOSSupport() error { | |||
| func CheckOSCapabilities(_ *Config) error { | |||
| return nil | |||
| } | |||
|
|
|||
| func KernelVersion() (major, minor int) { | |||
| return 5, 17 | |||
There was a problem hiding this comment.
should this now be 4, 18? Or does it even matter?
There was a problem hiding this comment.
Does not matter. It's just dummy stuff to let the linter/unit test compiler pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.