Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Invalid code editor loaded for Grafana versions that don't follow semantic versioning #506

Merged
merged 2 commits into from
Nov 22, 2022
Merged

Fix: Invalid code editor loaded for Grafana versions that don't follow semantic versioning #506

merged 2 commits into from
Nov 22, 2022

Conversation

aangelisc
Copy link
Contributor

@aangelisc aangelisc commented Nov 1, 2022 •
edited
Loading

Will correctly handle security releases by coercing the version into a value that follows semver rules.

Fixes #505

@aangelisc aangelisc requested a review from a team as a code owner November 1, 2022 18:48
@aangelisc aangelisc requested review from asimpson and yaelleC November 1, 2022 18:48
@github-actions
Copy link

github-actions bot commented Nov 1, 2022

Backend code coverage report for PR #506
No changes

@github-actions
Copy link

github-actions bot commented Nov 1, 2022

Frontend code coverage report for PR #506

Plugin Main PR Difference
src 78.79% 78.79% 0%

asimpson
asimpson approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@asimpson asimpson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 nice work!

✅ tests pass
✅ solves the issue

I left two nit comments but this works for me!

src/components/LegacyQueryEditor/RawQueryEditor.tsx Outdated Show resolved Hide resolved
src/components/LegacyQueryEditor/RawQueryEditor.tsx Outdated Show resolved Hide resolved
@andresmgot andresmgot added the changelog PRs to include in the CHANGELOG label Nov 22, 2022
@andresmgot andresmgot changed the title Handle security release versions appropriately Fix: Invalid code editor loaded for Grafana versions that don't follow semantic versioning Nov 22, 2022
@aangelisc aangelisc merged commit 2cd06cb into main Nov 22, 2022
@aangelisc aangelisc deleted the fix-version-parsing branch November 22, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asimpson asimpson asimpson approved these changes

@andresmgot andresmgot andresmgot approved these changes

@yaelleC yaelleC Awaiting requested review from yaelleC yaelleC is a code owner automatically assigned from grafana/partner-datasources

Assignees
No one assigned
Labels
changelog PRs to include in the CHANGELOG effort/small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid code editor loaded for Grafana versions that don't follow semantic versioning
3 participants
@aangelisc @asimpson @andresmgot