Fix references to text_file collector and lack ofdns config conversion
#4024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dehaansa
added
type/docs
|
💻 Deploy preview deleted. |
docs/sources/reference/components/prometheus/prometheus.exporter.windows.md
Outdated
Show resolved
Hide resolved
…er.windows.md Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
docs/sources/reference/components/prometheus/prometheus.exporter.windows.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/prometheus/prometheus.exporter.windows.md
Outdated
Show resolved
Hide resolved
…er.windows.md Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
clayton-cornell
approved these changes
Jul 23, 2025
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-4024-to-release/v1.10 origin/release/v1.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 12d94d36ff44c92c34962ac4183ab8d29ab0c373
# Push it to GitHub
git push --set-upstream origin backport-4024-to-release/v1.10
git switch main
# Remove the local backport branch
git branch -D backport-4024-to-release/v1.10Then, create a pull request where the |
dehaansa
added a commit
that referenced
this pull request
Jul 24, 2025
…rsion (#4024) * Fix references to collector * Ensure DNS config is appropriately converted for windows exporter * add changelog * Update docs/sources/reference/components/prometheus/prometheus.exporter.windows.md Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com> * Update blurb about text_file/textfile in windows docs * Update docs/sources/reference/components/prometheus/prometheus.exporter.windows.md Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com> --------- Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com> (cherry picked from commit 12d94d3)
dehaansa
added a commit
that referenced
this pull request
Jul 24, 2025
…rsion (#4024) (#4049) * Fix references to collector * Ensure DNS config is appropriately converted for windows exporter * add changelog * Update docs/sources/reference/components/prometheus/prometheus.exporter.windows.md * Update blurb about text_file/textfile in windows docs * Update docs/sources/reference/components/prometheus/prometheus.exporter.windows.md --------- (cherry picked from commit 12d94d3) Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
A user encountered an issue caused by two issues, with one hiding the other.
dnscollector's configuration was not appropriately copied down from Alloy config to exporter config.textfilecollector's documentation & config block referencetext_filewhich led to the user configuring theenabled_collectorsincorrectly.Internal to the exporter, config validation first reported the issues caused by the
dnscollector even if it was not used and did not report thetext_filecollector name being incorrect.