Skip to content

Added resource samples #2259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

xogoodnow
Copy link

@xogoodnow xogoodnow commented Dec 11, 2024

PR Description

Added resource limit/request samples.
Commented out the resources.requests section for config reloader.

Which issue(s) this PR fixes

It is more convenient

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

Signed-off-by: xogoodnow <xo4ever9999@gmail.com>
@xogoodnow xogoodnow requested a review from a team as a code owner December 11, 2024 14:29
Copy link
Contributor

This PR has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If you do not have enough time to follow up on this PR or you think it's no longer relevant, consider closing it.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your PR will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

@xogoodnow
Copy link
Author

Hi,
What seems to be the issue for this PR to move forward?

@ptodev ptodev self-assigned this Feb 28, 2025
Copy link
Collaborator

@ptodev ptodev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late response! I've been trying to learn more about Helm so I had a quick look and left a comment. We don't have many folks familiar with Helm on the team right now, which is probably why the PR didn't get a review earlier.

Comment on lines +175 to +180
# limits:
# cpu: "1m"
# memory: "5Mi"
# requests:
# cpu: "1m"
# memory: "5Mi"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, you are doing this so that you can set resources as a whole rather than resources/request/cpu and resources/request/memory individually? Isn't there still a way to set resources as a whole, without having to tweak the cpu and memory params individually?

Also, wouldn't this break users who rely on the current defaults?

@CLAassistant
Copy link

CLAassistant commented Apr 2, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants