-
Notifications
You must be signed in to change notification settings - Fork 310
Added resource samples #2259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Added resource samples #2259
Conversation
Signed-off-by: xogoodnow <xo4ever9999@gmail.com>
This PR has not had any activity in the past 30 days, so the |
Hi, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late response! I've been trying to learn more about Helm so I had a quick look and left a comment. We don't have many folks familiar with Helm on the team right now, which is probably why the PR didn't get a review earlier.
# limits: | ||
# cpu: "1m" | ||
# memory: "5Mi" | ||
# requests: | ||
# cpu: "1m" | ||
# memory: "5Mi" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC, you are doing this so that you can set resources
as a whole rather than resources/request/cpu
and resources/request/memory
individually? Isn't there still a way to set resources
as a whole, without having to tweak the cpu and memory params individually?
Also, wouldn't this break users who rely on the current defaults?
|
PR Description
Added resource limit/request samples.
Commented out the resources.requests section for config reloader.
Which issue(s) this PR fixes
It is more convenient
PR Checklist