Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: Go mod webdevops/go-common version bump. #1837

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dtrejod
Copy link
Contributor

@dtrejod dtrejod commented Oct 7, 2024

PR Description

This PR updates to the latest commit webdevops/go-common which importantly contains the following PR: webdevops/go-common#7.

Now a user can set AZURE_ENVIRONMENT: AzureSecretCloud and provide a corresponding AZURE_CLOUD_CONFIG: <JSON> or AZURE_CLOUD_CONFIG_FILE: /path/to/file with Azure secret cloud endpoints to have grafana-agent gather metrics from azure secret cloud regions.

Which issue(s) this PR fixes

Notes to the Reviewer

Do we want changelogs for a go mod bump?

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@dtrejod dtrejod requested a review from a team as a code owner October 7, 2024 13:50
@mattdurham
Copy link
Collaborator

@dtrejod thoughts on adding some documentation for the env vars?

@clayton-cornell
Copy link
Contributor

clayton-cornell commented Oct 7, 2024

The Env Vars topic is here: https://grafana.com/docs/alloy/latest/reference/cli/environment-variables/ It'd be super helpful to add these new vars to this topic

@dtrejod
Copy link
Contributor Author

dtrejod commented Oct 7, 2024

I can look to add docs. Let me throw a dev build on an environment to see exactly the full set of endpoints one needs to specify in the AZURE_CLOUD config envvar to get basic azure secret cloud metric collection working.

Copy link
Contributor

github-actions bot commented Nov 7, 2024

This PR has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If you do not have enough time to follow up on this PR or you think it's no longer relevant, consider closing it.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your PR will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants