Enable Oauth2 for most http-based notifiers #355
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #338
This PR contains two commits:
http_configinto a more central area so it can be easily extended to other notifiers and their tests.http_configis now un-marshalled separate from the notifier-specific configuration.Testing of the common HTTP config options (currently just oauth2) is fairly comprehensive and centralized in notify/receivers_test.go instead of spread out among each notifier's package tests. The tests use mock servers to ensure the token is actually being correctly retrieved from the oauth2 server and the
Authorizationheader set on outgoing http calls.Notifiers not yet supported and why: