Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(otelcol/extension/jaeger_remote_sampling): resync defaults with upstreams #6763

Closed
wants to merge 4 commits into from
Closed

feat(otelcol/extension/jaeger_remote_sampling): resync defaults with upstreams #6763

wants to merge 4 commits into from

Conversation

hainenber
Copy link
Contributor

PR Description

As of writing, the upstream has agreed upon limiting binding IP address to be localhost instead of 0.0.0.0 for security reasons. This PR is to reflect that upstream change.

Which issue(s) this PR fixes

Fixes grafana/alloy#219

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

hainenber and others added 4 commits March 24, 2024 13:29
@hainenber
feat(otelcol/extension/jaeger_remote_sampling): resync defaults with …
c2cb89c 
…upstreams

Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber
Merge branch 'main' into resync-defaults-for-jaeger-remote-sampling
439aab9
@hainenber
chore(doc): update CHANGELOG entry
a5e3a36 
Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber
fix(otelcol/extension/jaeger_remote_sampling): resync unit tests
4fc0733 
Signed-off-by: hainenber <dotronghai96@gmail.com>
tpaschalis
tpaschalis reviewed Apr 4, 2024
View reviewed changes
...ponent/otelcol/extension/jaeger_remote_sampling/internal/jaegerremotesampling/config_test.go
@@ -27,9 +27,9 @@ func TestLoadConfig(t *testing.T) {
{
id: component.NewID(typeStr),
expected: &Config{
HTTPServerConfig: &confighttp.ServerConfig{Endpoint: ":5778"},
HTTPServerConfig: &confighttp.ServerConfig{Endpoint: "localhost:5778"},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might be surprising to users, as suddenly telemetry might be not be able to get pushed anymore.

Looking at the upstream docs I think the default is 0.0.0.0 for this reason. Can we align it with that value?

Once we start supporting OTel Collector feature gates (eg. such as component.UseLocalHostAsDefaultHost) then it might make sense to also support this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tpaschalis If you look at this discussion upstream, they're working towards changing the default to 127.0.0.1 in a future release. Currently if you enable a specific feature gate (UseLocalHostAsDefaultHost) then all the components default to 127.0.0.1 instead.

I think we need to figure out if we're going to do this before 1.0, since it would be a breaking change when it does get implememnted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is pretty breaking, maybe we can park this one and accept the deviance as part of grafana/agent features. Not sure how we can reconcile with upstream for this one.

@hainenber hainenber marked this pull request as draft April 5, 2024 16:16
@rfratto rfratto added variant/flow Relatd to Grafana Agent Flow. enhancement New feature or request labels Apr 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If you do not have enough time to follow up on this PR or you think it's no longer relevant, consider closing it.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your PR will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

@github-actions github-actions bot added the needs-attention An issue or PR has been sitting around and needs attention. label May 10, 2024
@hainenber hainenber closed this Jun 2, 2024
@hainenber hainenber deleted the resync-defaults-for-jaeger-remote-sampling branch June 2, 2024 14:57
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Jul 3, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rfratto rfratto rfratto left review comments

@tpaschalis tpaschalis tpaschalis left review comments

Assignees
No one assigned
Labels
enhancement New feature or request frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. needs-attention An issue or PR has been sitting around and needs attention. variant/flow Relatd to Grafana Agent Flow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resync defaults for otelcol.extension.jaeger_remote_sampling with upstream
3 participants
@hainenber @rfratto @tpaschalis