Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline tests #6726

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Pipeline tests #6726

wants to merge 11 commits into from

Conversation

thampiotr
Copy link
Contributor

PR Description

This demonstrates how we can run the agent programmatically with a fully-fledged config file and some fake source and destination endpoints.

I think that this approach has some benefits:

  • It can run quite fast, without delaying the CI pipeline*
  • It verifies that components integrate with each other
  • will expose a wide range of breaking changes to configs if made by accident or when a dependency is updated
  • can be used to check for regressions against some of the most common customer pipelines
  • the configs can be used as examples too in the docs, so we can verify that our examples work
  • we can debug and step through these with IDE

Some of the cons are:

  • Need to add fake implementations of external stuff. Sometimes it's easy, but sometimes it may be harder, e.g. for some exporters.
  • it is some extra code, but hopefully copying and tweaking existing examples is simple enough

*this is currently not quite the case for prometheus due to WAL, but we can probably improve it with some effort.

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@rfratto rfratto added variant/static Related to Grafana Agent Static. variant/flow Relatd to Grafana Agent Flow. enhancement New feature or request labels Apr 9, 2024
Copy link
Contributor

This PR has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If you do not have enough time to follow up on this PR or you think it's no longer relevant, consider closing it.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your PR will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

@github-actions github-actions bot added the needs-attention An issue or PR has been sitting around and needs attention. label May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-attention An issue or PR has been sitting around and needs attention. variant/flow Relatd to Grafana Agent Flow. variant/static Related to Grafana Agent Static.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants