Use a more portable method of detecting the current script's directory #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method used before relied on GNU readlink's -e CLI flag, which isn't supported on the version of readlink shipped with BSD and MacOs. Finding the current script's directory is tricky business. There are many StackOverflow questioins on this very topic, and many opinions on the "best" way to do it. The solution in this commit was carefully selected after reviewing many sources of information on the topic. Below are references to the most useful sources: * [Reliable way for a Bash script to get the full path to itself [duplicate]](https://stackoverflow.com/questions/4774054/reliable-way-for-a-bash-script-to-get-the-full-path-to-itself): * This is the best question on Stack Overflow because the question contains a specific set of requiremewnts (which are very close to our own requirements). In particular, [this answer](https://stackoverflow.com/a/9107028/106189) is helpful. * [Determining the Location of Your Script in Bash](https://www.binaryphile.com/bash/2020/01/12/determining-the-location-of-your-script-in-bash.html): * This is an excellent blog post which walks through and explains the solution in detail.
|
Thanks, @jthurne . |
jthurne
force-pushed
the
jhurne/portable-script-dir
branch
from
f7b124e to
8bcff46
Compare
etiennestuder
approved these changes
Feb 6, 2022
|
@jthurne I cannot review it technically but I'm sure this is an improvement if you raise it. Feel free to merge this. Just curious: was this PR motivated by someone reporting an issue? |
davidmc24
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method used before relied on GNU readlink's -e CLI flag, which isn't supported on the version of readlink shipped with BSD and MacOs.
Finding the current script's directory is tricky business. There are many StackOverflow questioins on this very topic, and many opinions on the "best" way to do it. The solution in this commit was carefully selected after reviewing many sources of information on the topic. Below are references to the most useful sources:
Reliable way for a Bash script to get the full path to itself [duplicate]
Determining the Location of Your Script in Bash