-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance Lite E2E tests and fix a networking problem on Lite #9333
Merged
+47
−4
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
019e6ab
Add Lite E2E test to check a matplotlib problem which was fixed in ht…
whitphx 6127fd7
Restore js/app/test/image_remote_url.spec.ts, which was deleted in ht…
whitphx 86b5572
Fix tootils import
whitphx adebecd
Format
whitphx d358a42
Fix processing_utils.resolve_with_google_dns to use the HTTPX client …
whitphx f4c3375
add changeset
gradio-pr-bot 05c8b97
add changeset
gradio-pr-bot e8de2bd
Move js/app/test/image_remote_url.spec.ts -> js/spa/test/image_remote…
whitphx c3f4504
Use pyodide.http in resolve_with_google_dns on Lite
whitphx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"gradio": minor | ||
--- | ||
|
||
feat:Enhance Lite E2E tests and fix a networking problem on Lite |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
import { test, expect } from "@self/tootils"; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh it got deleted? |
||
|
||
test("Image displays remote image correctly", async ({ page }) => { | ||
const example_image = page.locator( | ||
'div.block:has(div.label:has-text("Examples")) img' | ||
); | ||
const input_image = page.locator( | ||
'div.block:has(label:has-text("InputImage")) img' | ||
); | ||
const loopback_image = page.locator( | ||
'div.block:has(label:has-text("Loopback")) img' | ||
); | ||
const remote_output_image = page.locator( | ||
'div.block:has(label:has-text("RemoteImage")) img' | ||
); | ||
const submit_button = page.locator('button:has-text("Submit")'); | ||
|
||
await expect(example_image).toHaveJSProperty("complete", true); | ||
await expect(example_image).not.toHaveJSProperty("naturalWidth", 0); | ||
|
||
await expect(input_image).toHaveJSProperty("complete", true); | ||
await expect(input_image).not.toHaveJSProperty("naturalWidth", 0); | ||
|
||
await submit_button.click(); | ||
|
||
await expect(loopback_image).toHaveJSProperty("complete", true); | ||
await expect(loopback_image).not.toHaveJSProperty("naturalWidth", 0); | ||
await expect(remote_output_image).toHaveJSProperty("complete", true); | ||
await expect(remote_output_image).not.toHaveJSProperty("naturalWidth", 0); | ||
}); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we used urllib originally because it was compatible with lite. Just wondering what the root cause is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's confusing but network requests through
urllib
don't work on Pyodide by default, whereurllib3
works.