-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set the color of placeholder in a disabled textbox to gray instead of black, and disable typing while a response is generating in gr.ChatInterface
, allow gr.MultimodalTextbox
to accept string values
#9328
Merged
Merged
Changes from 7 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
779f7cc
textbox
abidlabs aab64e0
add changeset
gradio-pr-bot 6f3fdb0
changes'
abidlabs a6e3125
revert demos
abidlabs c43ab45
add changeset
gradio-pr-bot 2464343
add changeset
gradio-pr-bot d236e21
changes
abidlabs 3f02fad
multimodal
abidlabs ed9abc5
add changeset
gradio-pr-bot 8a3dd08
changes
abidlabs 9def3b0
format
abidlabs 1d153f0
revert demo
abidlabs ec254d6
Merge branch '5.0-dev' into disabled-textbox-placeholder
abidlabs 49b3a77
fix test
abidlabs a43c0da
Merge branch 'disabled-textbox-placeholder' of github.com:gradio-app/…
abidlabs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
"@gradio/textbox": patch | ||
"gradio": patch | ||
--- | ||
|
||
fix:Set the color of placeholder in a disabled textbox to gray instead of black, and disable typing while a response is generating in `gr.ChatInterface` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really like the placeholder because we've already cleared the textbox and the user message is displayed in the chatbot.
Minor point though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah okay I can just get rid of it, no strong feelings on my part