Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more typing to event listeners #9079

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Add more typing to event listeners #9079

merged 2 commits into from
Aug 12, 2024

Conversation

JackismyShephard
Copy link
Contributor

Description

This adds more typing definitions that I forgot to add in #8983

Closes: #8928

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Aug 10, 2024 •
edited
Loading

🪼 branch checks and previews

• Name Status URL
Website ready! Website preview
🦄 Changes detected! Details

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Aug 10, 2024 •
edited
Loading

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Add more typing to event listeners

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?
  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@JackismyShephard
Copy link
Contributor Author

@freddyaboulton Should be ready for review now

abidlabs
abidlabs reviewed Aug 11, 2024
View reviewed changes
gradio/blocks.py Outdated Show resolved Hide resolved
abidlabs
abidlabs approved these changes Aug 11, 2024
View reviewed changes
Copy link
Member

@abidlabs abidlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with the one suggestion above

freddyaboulton
freddyaboulton approved these changes Aug 12, 2024
View reviewed changes
gradio/component_meta.py Show resolved Hide resolved
@JackismyShephard JackismyShephard force-pushed the add-more-typing-to-event-listeners branch 3 times, most recently from 902e58b to d336ef9 Compare August 12, 2024 17:21
@JackismyShephard
add more typing to event listeners
3f1debf 
Add more specific typing for auth callable
@JackismyShephard JackismyShephard force-pushed the add-more-typing-to-event-listeners branch from 63bf41e to 3f1debf Compare August 12, 2024 17:27
@JackismyShephard
Copy link
Contributor Author

@abidlabs Should be ready for merging into main now

@abidlabs
Copy link
Member

abidlabs commented Aug 12, 2024 •
edited
Loading

Nice, thanks @JackismyShephard! merging

@abidlabs abidlabs merged commit d6dc384 into gradio-app:main Aug 12, 2024
18 checks passed
This was referenced Aug 12, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abidlabs abidlabs abidlabs approved these changes

@freddyaboulton freddyaboulton freddyaboulton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Insufficient typing of event listener functions
4 participants
@JackismyShephard @gradio-pr-bot @abidlabs @freddyaboulton