Allow drag and replace image in gr.Image and Multimodal textbox
#9031
Conversation
hannahblair
changed the title
hannahblair
changed the title
gr.Image and gr.ImageEditor
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/ea00cb2d25b6adadd4753d09648d91bbc8a61df9/gradio-4.41.0-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@ea00cb2d25b6adadd4753d09648d91bbc8a61df9#subdirectory=client/python"Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/ea00cb2d25b6adadd4753d09648d91bbc8a61df9/gradio-client-1.5.0.tgz |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
…to upload-drag
…to upload-drag
| @@ -14,7 +14,6 @@ | |||
| export let upload: Client["upload"]; | |||
| export let stream_handler: Client["stream"]; | |||
|
|
|||
| let upload_component: Upload; | |||
There was a problem hiding this comment.
removed bc not used
| flex-grow: 0; | ||
| } | ||
|
|
||
| .hidden :global(svg) { |
There was a problem hiding this comment.
hides the webcam icon
|
I have no idea why the story tests are showing a dataframe diff |
|
Works great for gr.Image but image_editor demo didn't allow a second drop: |
hannahblair
changed the title
gr.Image and gr.ImageEditorgr.Image
|
Hmm, it was working at one point, but I realised that when it was working, you couldn't actually draw or erase because the upload container z-index was too high, but we need it at a certain z-index for us to recognise that we're actually dragging an image. I think the |
There was a problem hiding this comment.
Works great @hannahblair ! Makes sense to do ImageEditor in a different PR
* allow uploading files via drag * wrap tweak * * fix input * improve a11y * fix thumbnail scrolling * tweak
|
merged #9125 here as that PR will fix the failing chatbot tests cc @dawoodkhan82 |
hannahblair
changed the title
gr.Imagegr.Image and Multimodal textbox
Description
Allows dragging an image over an
Imageandcomponent even when an image is already in place.ImageEditorCloses: #8535
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.shYou may need to run the linters:
bash scripts/format_backend.shandbash scripts/format_frontend.sh