Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unexpected rendering of Dataset #8987

Merged
merged 3 commits into from
Aug 9, 2024

Conversation

Col0ring
Copy link
Contributor

@Col0ring Col0ring commented Aug 5, 2024

Description

Please include a concise summary, in clear English, of the changes in this pull request. If it closes an issue, please mention it here.

Closes: #8936

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Aug 5, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website building...
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/4afccc61e210ce1ba60f674398ce4f53c983815d/gradio-4.41.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@4afccc61e210ce1ba60f674398ce4f53c983815d#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/4afccc61e210ce1ba60f674398ce4f53c983815d/gradio-client-1.5.0.tgz

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Aug 5, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/dataset patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Fix unexpected rendering of Dataset

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@Col0ring
Copy link
Contributor Author

Col0ring commented Aug 5, 2024

Hmm... the failure doesn't seem to be due to my changes...

@freddyaboulton
Copy link
Collaborator

Thank you @Col0ring ! This looks good to me

@freddyaboulton freddyaboulton merged commit 7b288cf into gradio-app:main Aug 9, 2024
19 checks passed
This was referenced Aug 9, 2024
@cornzz
Copy link
Contributor

cornzz commented Sep 17, 2024

Thanks for this @Col0ring, I noticed there was some infinite loop going in my gradio app, slowing the whole app down after a while and I eventually realized its coming from the dataset component. Glad theres already a fix and I just have to update gradio...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gr.Dataset is rendered infinitely on the frontend
4 participants