Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix param table rendering #8825

Merged
merged 3 commits into from
Jul 18, 2024
Merged

Fix param table rendering #8825

merged 3 commits into from
Jul 18, 2024

Conversation

aliabd
Copy link
Collaborator

@aliabd aliabd commented Jul 17, 2024

What's happening is paramviewer's styling references css variables defined in the gradio theme, which is not on the page. The simplest fix i could think of was to just import the stylesheet from here: https://gradio-hello-world.hf.space/theme.css

I already do that for lite demos on the website. Which is why you'll only see this error when directly navigating to a page without demos or embedded components, for example: https://www.gradio.app/docs/gradio/render

@aliabd aliabd requested a review from abidlabs July 17, 2024 23:44
@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jul 17, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
🦄 Changes detecting...

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/4640c90f680ae60e12b25e425aa45fa78862ac64/gradio-4.38.1-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@4640c90f680ae60e12b25e425aa45fa78862ac64#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-builds.s3.amazonaws.com/4640c90f680ae60e12b25e425aa45fa78862ac64/gradio-client-1.3.0.tgz

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jul 17, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
website patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Fix param table rendering

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@abidlabs
Copy link
Member

Thanks @aliabd! Can confirm that this fixes the issue

@abidlabs abidlabs added the v: patch A change that requires a patch release label Jul 18, 2024
@abidlabs abidlabs merged commit b45d37f into main Jul 18, 2024
8 checks passed
@abidlabs abidlabs deleted the aliabd/param-bug branch July 18, 2024 06:37
This was referenced Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v: patch A change that requires a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants