Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with virtual module in custom components #8761

Merged
merged 4 commits into from
Jul 12, 2024
Merged

Conversation

pngwn
Copy link
Member

@pngwn pngwn commented Jul 12, 2024

Description

Please include a concise summary, in clear English, of the changes in this pull request. If it closes an issue, please mention it here.

Fixes #8661.

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@pngwn pngwn changed the title fix bug Fix issue with virtual module in custom components Jul 12, 2024
@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jul 12, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/396121f9b77c50f2e3f54e7debd16cd488f46489/gradio-4.37.2-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@396121f9b77c50f2e3f54e7debd16cd488f46489#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-builds.s3.amazonaws.com/396121f9b77c50f2e3f54e7debd16cd488f46489/gradio-client-1.2.1.tgz

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jul 12, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/preview patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Fix issue with virtual module in custom components

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@pngwn
Copy link
Member Author

pngwn commented Jul 12, 2024

To test:

cd js/preview
pnpm build
cd test
gradio cc create MyComponent --template SimpleTextbox
cd mycomponent
pnpm i
gradio cc dev

On main it breaks, in this PR it doesn't.

Copy link
Collaborator

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the issue thanks @pngwn !

@pngwn pngwn merged commit 078663a into main Jul 12, 2024
8 checks passed
@pngwn pngwn deleted the 8661-utils-refactor branch July 12, 2024 17:34
@pngwn pngwn mentioned this pull request Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error following custom components docs gradio cc dev (virtual:component-loader)
3 participants