Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Share to community button for images #8737

Merged
merged 20 commits into from
Jul 11, 2024
Merged

Fix Share to community button for images #8737

merged 20 commits into from
Jul 11, 2024

Conversation

hannahblair
Copy link
Collaborator

@hannahblair hannahblair commented Jul 10, 2024

Description

For images, the value object was being passed to uploadToHuggingFace with the param base64 so processing the url was causing an error.

Devtools screenshot of this for more context:

Screenshot 2024-07-10 at 14 38 32

Test space: https://huggingface.co/spaces/hmb/testshare

Closes: #8729

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jul 10, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website building...
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/f3cbef3ac76670a51743b67557357ce18adca1c0/gradio-4.37.2-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@f3cbef3ac76670a51743b67557357ce18adca1c0#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-builds.s3.amazonaws.com/f3cbef3ac76670a51743b67557357ce18adca1c0/gradio-client-1.2.1.tgz

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jul 10, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/image patch
@gradio/utils patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Fix Share to community button for images

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

Copy link
Member

@pngwn pngwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, i think is from a time when we base64 encoded image.

Thanks for taking care of this @hannahblair!

@hannahblair hannahblair marked this pull request as ready for review July 11, 2024 12:00
@hannahblair hannahblair merged commit 31a876d into main Jul 11, 2024
9 checks passed
@hannahblair hannahblair deleted the fix-share-btn branch July 11, 2024 17:15
@pngwn pngwn mentioned this pull request Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sharing to community is broken on Hugging Face
3 participants