Chatbot LaTeX Crash Fix #8658
Merged
Chatbot LaTeX Crash Fix #8658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/2178a090bc5187971cb15180210bea20e67c0d07/gradio-4.37.2-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@2178a090bc5187971cb15180210bea20e67c0d07#subdirectory=client/python"Install Gradio JS Client from this PR npm install https://gradio-builds.s3.amazonaws.com/2178a090bc5187971cb15180210bea20e67c0d07/gradio-client-1.2.1.tgz |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
|
Can't seem to figure out this bug. This fix helps, but doesn't fully resolve the error: @pngwn if you get a chance, could use a second set of eyes. |
pngwn
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
Ah interesting! Just one small comment but otherwise looks great. Thanks @dawoodkhan82!
Comment on lines
76
to
78
| onMount(() => { | ||
| el = document.getElementById("container") as HTMLSpanElement; | ||
| }); |
There was a problem hiding this comment.
This is essentially the same as the binding, does just having the condition in the afterUpdate address this issue?
There was a problem hiding this comment.
Nope, it still crashes half the time. Seems like KaTex doesn't play well with svelte since both manipulate the DOM.
* styling for codeblocks * add changeset * formatting * add changeset * changes --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com> Co-authored-by: Abubakar Abid <abubakar@huggingface.co>
* display modes * add changeset * test fixes * lint * Update gradio/components/model3d.py Co-authored-by: Abubakar Abid <abubakar@huggingface.co> * solid --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com> Co-authored-by: Abubakar Abid <abubakar@huggingface.co>
* Fix the Playground on the website to trigger run_code() and install() with debounce and to display errors * Remove an unused function, make_full_screen() * Format demo/hello_world/run.py * Update notebook * add changeset * add changeset --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>
#8705) * GRADIO_ALLOWED_PATHS & GRADIO_BLOCKED_PATHS comma separated environment variables * GRADIO_ALLOWED_PATHS & GRADIO_BLOCKED_PATHS comma separated environment variables * add changeset * Document GRADIO_ALLOWED_PATHS and GRADIO_BLOCKED_PATHS --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com> Co-authored-by: Abubakar Abid <abubakar@huggingface.co>
…e Blocks.config object (#8720) * auth docs * changes * add changeset * add changeset * add changeset * type * changes * snippets * import * add changeset * changes * fix typing --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>
dawoodkhan82
commented
Jul 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this fix, it seems to be crashing a lot less. Also doesn't seem like the Latex is being rendered correctly anymore.
Closes: #8006
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.shYou may need to run the linters:
bash scripts/format_backend.shandbash scripts/format_frontend.sh