fix space embeds using src attribute
#3065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-3065-all-demos |
freddyaboulton
approved these changes
Jan 27, 2023
tomchang25
pushed a commit
to tomchang25/gradio
that referenced
this pull request
Feb 2, 2023
* Fix bug * CHANGELOG demo fix-tabs (gradio-app#3055) * fix-tabs * Reformat changelog Co-authored-by: freddyaboulton <alfonsoboulton@gmail.com> video-bug-demo Another bug Fix video and file events bugs demo.ipynb fix space embeds using `src` attribute (gradio-app#3065) * change ports in dev mode * changelog * correctly detect space embeds * changelog * formatting fix css scoping (gradio-app#3059) Fix auth on spaces (gradio-app#3049) * Add route alias * on button click * Fix config * Do not redirect * Use login to check if other route necessary * Add message about HF spaces * CHANGELOG * Add gif to changelog Fix Sketch clearing bug (gradio-app#3047) * bug fix * changelog * undo fix Release version 3.17.0 (gradio-app#3074) * version 3.17.0 * changelog New Version Docs (gradio-app#3087) Chatbot loader (gradio-app#3079) * changes * chagnes * changes * changes * changes * changes --------- Co-authored-by: Abubakar Abid <abubakar@huggingface.co> Changelog and format front changelog fix Change demo video and image Fix image rotation on iOS (gradio-app#3091) * rotate image based on exif tag * rotate on backend * CHANGELOG * Only rotate if needed * Add image comparison to changelog --------- Co-authored-by: Dawood Khan <dawoodkhan82@gmail.com> Set minimum markdown-it-py version to 2.0.0 (gradio-app#3102) * Bump requirements * CHANGELOG only mount fonts in prod mode (gradio-app#3100) * only mount fonts in prod mode * cleanup --------- Co-authored-by: aliabid94 <aabid94@gmail.com> Fix change event listener (gradio-app#3095) * changes * changes --------- Co-authored-by: Abubakar Abid <abubakar@huggingface.co> Co-authored-by: pngwn <hello@pngwn.io> [Minor] Correct link (gradio-app#3109) * Correct link * Update CHANGELOG.md Enable gradio to work on kaggle (gradio-app#3101) * enable share kaggle * Add test * CHANGELOG * Add image to changelog Fix example gallery mode (gradio-app#3090) * Fix example gallery mode * CHANGELOG fix changelog fix changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed the ports in dev mode.
Currently if you try to embed a gradio app (via a space) and run your embedding app locally on port 3000 (which is pretty much a default), the gradio SDK will make requests to
localhost:3000/x/xrather than the space because of some special handling we have for production testing. This PR changes the local port to something ridiculous which should make it so that these kinds of problems never occur (for most people).Kind of closes #2880 although I can't actually reproduce that issue.
Edit: I finally figured out #2880. It was due to the
srcattribute on the web component (rather thanhostorspace). I think we can combine those three attributes into one. Details are here: #2880 (comment)Definitely fixes #2880 now.
Please include:
Closes: # (issue)
Checklist:
A note about the CHANGELOG
Hello 👋 and thank you for contributing to Gradio!
All pull requests must update the change log located in CHANGELOG.md, unless the pull request is labeled with the "no-changelog-update" label.
Please add a brief summary of the change to the Upcoming Release > Full Changelog section of the CHANGELOG.md file and include
a link to the PR (formatted in markdown) and a link to your github profile (if you like). For example, "* Added a cool new feature by
[@myusername](link-to-your-github-profile)in[PR 11111](https://github.com/gradio-app/gradio/pull/11111)".If you would like to elaborate on your change further, feel free to include a longer explanation in the other sections.
If you would like an image/gif/video showcasing your feature, it may be best to edit the CHANGELOG file using the
GitHub web UI since that lets you upload files directly via drag-and-drop.